Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Use --strict in twine check #144

Merged
merged 3 commits into from Jan 4, 2021
Merged

MNT: Use --strict in twine check #144

merged 3 commits into from Jan 4, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Dec 24, 2020

Follow up of pypa/twine#715 (comment)

With --strict, twine check will fail if there are warnings, preventing a release until they are fixed.

@pllim pllim added this to the 0.9.0 milestone Dec 24, 2020
@pllim pllim requested a review from saimn December 24, 2020 15:58
pllim and others added 2 commits December 28, 2020 11:42
@pllim @bsipocz
Pin twine version in workflow.
a296154 
Co-authored-by: Brigitta Sipocz <bsipocz@gmail.com>
@pllim
Put quotes around pip pinning
4292dcc
@bsipocz bsipocz merged commit 37721eb into scientific-python:master Jan 4, 2021
@bsipocz
Copy link
Member

bsipocz commented Jan 4, 2021

Thanks!

@pllim pllim deleted the twine-3.3-strict branch January 4, 2021 21:19
@saimn
Copy link
Contributor

saimn commented Jan 5, 2021

Thanks @pllim ! I'm lagging a bit with reviews etc. ;)

@bsipocz
Copy link
Member

bsipocz commented Jan 5, 2021

Me too, this was just an easy one off this list while I was around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsipocz bsipocz bsipocz approved these changes

@saimn saimn Awaiting requested review from saimn

Assignees
No one assigned
Labels
enhancement no-changelog-entry-needed
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pllim @bsipocz @saimn