Remove old admin column from users table #2000
Conversation
|
Thanks for figuring out the precision/Rails 7 stuff, and for link. I haven't completely wrapped my head around all details. You didn't make manual changes to the schema.rb, that changes are the result of letting Rails migrate it, correct? So you're confident it accurately represents our current database? Approved assuming that's so. |
|
Ideally, the commit message for the schema change would include more information about how those changes were made, as well as a link to the relevant Rails docs there. That's more a note for the future than a requirement you rewrite the commit message now. 🤷 |
remove obsolete admin? method note: this is our first rails migration since we moved to rails 7, so schema.rb specifies the rails version and changes the precision default for datetime columns. see: https://rubyonrails.org/2022/2/11/this-week-in-rails-rails-7-0-2-schema-versioning-based-on-the-rails-version-and-more-cbcb0592 rails/rails#44286
eddierubeiz
force-pushed
the
remove_old_admin_column
branch
from
bc04253
to
c368906
Compare
|
Confirmed -- the changes were automatic and would have been applied to the schema file in any case. |
Ref #1948
Remove the now-obsolete
admincolumn and the correspondingadmin?user method.This is our first migration since we moved to Rails 7, so this PR also includes some unrelated changes to
schema.rb. Notably, the default precision fordatetimecolumns is changing from 0 to 6. (more info)See also: rails/rails#44286