Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate mod files to reduce indirect dependencies #2

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

bbrks
Copy link
Contributor

@bbrks bbrks commented Nov 6, 2019

Fixes #1

Recreated mod files to remove the unused/indirect dependencies, and bumped versions:

  • Removed all dependencies not required for building the project
  • Bumped github.com/prometheus/client_golang from v1.0.0 to v1.2.1

Steps ran to get to this point:

$ rm go.mod
$ rm go.sum
$ go mod init
$ go mod tidy

Allows project to be buildable out of the box:

$ git clone --branch bump_deps git@github.com:bbrks/fping-exporter.git bbrks-fping-exporter
Cloning into 'bbrks-fping-exporter'...
remote: Enumerating objects: 44, done.
remote: Counting objects: 100% (44/44), done.
remote: Compressing objects: 100% (32/32), done.
remote: Total 44 (delta 16), reused 36 (delta 11), pack-reused 0
Receiving objects: 100% (44/44), 280.09 KiB | 647.00 KiB/s, done.
Resolving deltas: 100% (16/16), done.
$ cd bbrks-fping-exporter/
$ go build
$ ls -l fping-exporter
.rwxr-xr-x 11M bbrks  6 Nov 13:06 fping-exporter*

@schweikert
Copy link
Owner

Thanks!

@schweikert schweikert merged commit aed1c26 into schweikert:master Apr 6, 2020
@bbrks bbrks deleted the bump_deps branch April 6, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails in Go 1.13 due to older golang-lint presense in mod file
2 participants