Finish() should update state.currentBytes #182
+5
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
Finish()
function setscurrentNum
and invokesAdd(0)
. While this correctly updatescurrentNum
, it does not correctly updatecurrentBytes
. As a result, ifOptionShowBytes
,OptionShowIts
, orOptionShowCount()
options are enabled, the displayed counts or iterations will reflect incomplete values after callingFinish()
.For example, consider the following Go code snippet:
This code results in the following output:
However, the expected output should reflect the completion of the progress bar: