Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/different tagnames in xmllist #955

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

e-kemal
Copy link

@e-kemal e-kemal commented May 24, 2018

Q A
Bug fix? no
New feature? yes
Doc updated yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #921
License Apache-2.0

Adds support for xml lists, in which the tag name depends on the type of object.

Kamil Ahmetzyanov added 5 commits April 27, 2018 17:43
Add field allowTypes in XmlCollection annotation
If allowTypes not null, XmlSerializationVisitor use him to choice tag name
If allowTypes not null, XmlDeserializationVisitor use him to choice entity type
@goetas
Copy link
Collaborator

goetas commented May 24, 2018

Very nice feature. Implementation a bit complex.

Attention that you are targeting the master branch, but probably your pr was made to work with the 1.x branch.

Is there a way to "make more elegant" changes is the xml (de)serialization visitors? currently it increases the complexity really a lot... in an already class

@e-kemal
Copy link
Author

e-kemal commented Aug 8, 2018

Hello.
What is the status of the PR? What it takes to be accepted?

@goetas
Copy link
Collaborator

goetas commented Aug 18, 2019

Hi, sorry if it took that long (more than a year...), but somehow I've missed this PR.

Are you still working on it or on something similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants