implement @SkipWhenEmpty for strings #883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoric
commented
Mar 7, 2018
leoric
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| Doc updated | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | Apache-2.0 |
|
Hi! Thanks for the contribution. |
goetas
reviewed
Mar 7, 2018
| return; | ||
| } | ||
| if ('' === $v) { | ||
| return; |
There was a problem hiding this comment.
indentation with 4 spaces here
added 2 commits
March 7, 2018 17:11
|
fixed formatting, made documentation more clear. Xml visitor don't need an update - you can't create an empty string node in xml. Yaml visitor doesn't handle this tag at all ATM |
|
When can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.