feat(exclusion): add new option "inheritedGroups" into GroupExclusionStrategy #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scyzoryck
reviewed
Feb 15, 2023
jdreesen
reviewed
Feb 15, 2023
|
@scyzoryck @jdreesen can you review again please ? |
goetas
reviewed
Feb 28, 2023
| @@ -72,7 +72,13 @@ public function initialize(string $format, VisitorInterface $visitor, GraphNavig | |||
| $this->metadataStack = new \SplStack(); | |||
|
|
|||
| if (isset($this->attributes['groups'])) { | |||
| $this->addExclusionStrategy(new GroupsExclusionStrategy($this->attributes['groups'])); | |||
| $strategy = new GroupsExclusionStrategy($this->attributes['groups']); | |||
There was a problem hiding this comment.
why not
$context = // ... get the context somehow
$g = new GroupsExclusionStrategy(['a', 'b'], true);
$context->addExclusionStrategy($g);?
In that way we do not need to add the enableInheritGroups method in the context. Ideally the context should know the less possible about the various exclusion strategies.
There was a problem hiding this comment.
Ok, i see, but i can't add 2 GroupsExclusionStrategy, one with inheritedGroups = false and an another one with inheritedGroups = true.
How can i configure this option with JMSerializerBundle for example ?
Thanks for you help
|
I like this because it introduces back #1071 in a backward compat way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions :
inherited_groupsin Context.php ?