Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 compatibility #1113

Merged
merged 9 commits into from Aug 18, 2019
Merged

PHP 7.4 compatibility #1113

merged 9 commits into from Aug 18, 2019

Conversation

goetas
Copy link
Collaborator

@goetas goetas commented Aug 8, 2019

Q A
Bug fix? yes
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? -
Fixed tickets #1111
License MIT

@goetas goetas changed the title Php 7.4 compat PHP 7.4 compat Aug 8, 2019
@goetas
Copy link
Collaborator Author

goetas commented Aug 8, 2019

some test failures are because of symfony/symfony#32796 and doctrine/annotations#273

@goetas goetas changed the title PHP 7.4 compat PHP 7.4 compatibility Aug 15, 2019
@goetas goetas mentioned this pull request Aug 16, 2019
@goetas goetas merged commit 1792fe2 into master Aug 18, 2019
@goetas goetas deleted the php-7-4-compat branch August 18, 2019 06:43
@sanmai
Copy link
Contributor

sanmai commented Sep 4, 2019

Can we have a release with this fix? Thank you.

@goetas
Copy link
Collaborator Author

goetas commented Sep 4, 2019

done in https://github.com/schmittjoh/serializer/releases/tag/3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants