New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #923 Enabled support for DefaultValuePropertyDriver #924
Fix #923 Enabled support for DefaultValuePropertyDriver #924
Conversation
dbojdo
commented
Mar 21, 2023
Q | A |
---|---|
Bug fix? | no |
New feature? | yes |
Doc updated | yes |
BC breaks? | no |
Deprecations? no | |
Tests pass? | yes |
Fixed tickets | #923 |
License | MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dbojdo for contribution! Changes looks fine however I wonder if it will introduce some breaking changes to the flow? May it should be configurable?
Well, we may go the same way as for the enums. Introduce a new config property like: default_value_support: true/false (false by default) and then respect it in the extension. |
I think it will be better way to safely release it as non major release :) |
Good for me! |
@dbojdo let me know then the config option is implemented, we can merge it |
@dbojdo what is the status of this? Are you willing to continue on this PR (add support for config) or can somebody else continue on it? |
Hey! Don't mind someone else to take over as I'm super short on time now. There's not much to be done but can't afford the context switch now. |
@Kozzi11 this that's been merged, thanks for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution!
@goetas - Could you run the tests & merge if they passes, please? :) Unfortunately I do not have access to merge in this repository :(
@goetas ping |