Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark about how to switch to camel case. #847

Closed
wants to merge 1 commit into from
Closed

Add remark about how to switch to camel case. #847

wants to merge 1 commit into from

Conversation

yyaremenko
Copy link

Q A
Bug fix? no
New feature? no
Doc updated yes
BC breaks? no
Deprecations? no
Tests pass? yes/
Fixed tickets #...
License MIT

Copy link
Collaborator

@goetas goetas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

jms_serializer:
...
property_naming:
id: 'jms_serializer.identical_property_naming_strategy'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what you are suggesting here is wrong. as you can read "identical_property_naming_strategy" means "use the same property name as in the class", does not mean camel case.

the right config for camel case is

    jms_serializer:
        ...
        property_naming:
          separator:  ''
          lower_case: false

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sooo,

let me make it clear - you knew the correct solution from the very beginning, and, instead of fixing the documentation yourself, here you told me to include the solution from here and, after I did that, now you are telling me the solution was wrong.

like, dude, are you okay? also, if you think I'm a clown here to entertain you with commits, you are probably very, very wrong.

@yyaremenko yyaremenko closed this Apr 5, 2021
@goetas
Copy link
Collaborator

goetas commented Apr 5, 2021

@yyaremenko

let me make it clear - you knew the correct solution from the very beginning, and, instead of fixing the documentation yourself, here you told me to include the solution from here and, after I did that, now you are telling me the solution was wrong.

I did not know the solution. I went to find it my self in order to review your PR. (as you could have done...)

like, dude, are you okay? also, if you think I'm a clown here to entertain you with commits, you are probably very, very wrong.

I receive more than 150 notifications per week from people having similar problems and solutions as you have. I try my best to answer (100% of it done in my free unpaid time) and it happen that some tickets stay there open for quite a while unless someone manages to document the right solution...

Now that you know the solution, why not make a PR and document it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants