Add autoconfigure for handlers #670
Conversation
|
good! :) |
| { | ||
| $container = $this->getContainerForConfig(array()); | ||
|
|
||
| if (!method_exists($container, 'registerForAutoconfiguration')) { |
There was a problem hiding this comment.
In which case the registerForAutoconfiguration does not exists? Shouldn't this check be done also in JMSSerializerExtension.php ?
There was a problem hiding this comment.
It's also done in the extension (line 22)
registerForAutoconfiguration was added in Symfony 3.3, so it's for <3.3 compatibility.
There was a problem hiding this comment.
... and I just saw that symfony-dependency-injection require is ^3.3 so theses checks can be removed.
There was a problem hiding this comment.
The minimum dependency injection is 3.3, so probably this check and also the other you found can be removed... Can you?
magnetik
force-pushed
the
autoconfigure-handlers
branch
from
66c33d1
to
7f920a5
Compare
|
Just saw that there is a branch for 2.x, should I rebase on it? |
|
The 2.x branch has 2.3 as minimum dep version for the symfony dependency injection, so probably you will have to rework your PR. Here is up to you... the 3.0 should be released in the next 30-50 days (but will require jms/serializer 2.0 and not all the depending libraries are already compatible with it). |
|
another PR for 2.x, is that fine for you? |
|
Closing as #671 has been merged. |
|
@magnetik Thanks for your contribution! |
Such like events we can auto configure handlers.
Also remove checks for
registerForAutoconfigurationassymfony/dependency-injectionrequired version is^3.3.