Merge pull request #671 from magnetik/autoconfigure-handlers-2.x

Add autoconfigure for handlers
schmittjoh · Jul 11, 2018 · 9fe4d5d · 9fe4d5d
2 parents 22eb9a2 + 3c90ba7
commit 9fe4d5d
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/DependencyInjection/JMSSerializerExtension.php b/DependencyInjection/JMSSerializerExtension.php
@@ -4,6 +4,7 @@
 
 use JMS\Serializer\EventDispatcher\EventSubscriberInterface;
 use JMS\Serializer\Exception\RuntimeException;
+use JMS\Serializer\Handler\SubscribingHandlerInterface;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\Alias;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
@@ -21,6 +22,10 @@ public function loadInternal(array $config, ContainerBuilder $container)
             $container
                 ->registerForAutoconfiguration(EventSubscriberInterface::class)
                 ->addTag('jms_serializer.event_subscriber');
+
+            $container
+                ->registerForAutoconfiguration(SubscribingHandlerInterface::class)
+                ->addTag('jms_serializer.subscribing_handler');
         }
 
         $loader = new XmlFileLoader($container, new FileLocator(array(

diff --git a/Tests/DependencyInjection/JMSSerializerExtensionTest.php b/Tests/DependencyInjection/JMSSerializerExtensionTest.php
@@ -3,6 +3,7 @@
 namespace JMS\SerializerBundle\Tests\DependencyInjection;
 
 use Doctrine\Common\Annotations\AnnotationReader;
+use JMS\Serializer\Handler\SubscribingHandlerInterface;
 use JMS\Serializer\SerializationContext;
 use JMS\Serializer\EventDispatcher\EventSubscriberInterface;
 use JMS\SerializerBundle\JMSSerializerBundle;
@@ -531,6 +532,22 @@ public function testAutoconfigureSubscribers()
         $this->assertTrue($autoconfigureInstance[EventSubscriberInterface::class]->hasTag('jms_serializer.event_subscriber'));
     }
 
+    public function testAutoconfigureHandlers()
+    {
+        $container = $this->getContainerForConfig(array());
+
+        if (!method_exists($container, 'registerForAutoconfiguration')) {
+            $this->markTestSkipped(
+                'registerForAutoconfiguration method is not available in the container'
+            );
+        }
+
+        $autoconfigureInstance = $container->getAutoconfiguredInstanceof();
+
+        $this->assertTrue(array_key_exists(SubscribingHandlerInterface::class, $autoconfigureInstance));
+        $this->assertTrue($autoconfigureInstance[SubscribingHandlerInterface::class]->hasTag('jms_serializer.subscribing_handler'));
+    }
+
     private function getContainerForConfig(array $configs, callable $configurator = null)
     {
         $bundle = new JMSSerializerBundle();