Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-1614/add-httpx-dependency #1615

Merged

Conversation

Bidaya0
Copy link
Contributor

@Bidaya0 Bidaya0 commented Sep 27, 2022

馃毃Please review the guidelines for contributing to this repository.

Description

Please explain the changes you made here.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Added a changelog entry
  • Extended the README / documentation, if necessary

try to fix : #1614

@Bidaya0 Bidaya0 force-pushed the issue-1614/add-httpx-dependency branch from 0f6bc45 to 92986da Compare September 28, 2022 02:28
@Bidaya0
Copy link
Contributor Author

Bidaya0 commented Sep 28, 2022

Any idea about the FileNotFoundError in windows?

I changed the pyproject.toml and locked it in linux.

Is there something I have not aware of?

@Bidaya0
Copy link
Contributor Author

Bidaya0 commented Sep 28, 2022

Added atomicwrites dependency on win32 platform, which was present in poetry.lock but not in pyproject.toml

@Stranger6667
Copy link
Member

I think it would be better to update pytest to 7.1.3 instead as they dropped atomicwrites

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #1615 (9b166c7) into master (2ddb105) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1615      +/-   ##
==========================================
+ Coverage   98.91%   99.04%   +0.13%     
==========================================
  Files          93       93              
  Lines        7526     7526              
  Branches     1334     1288      -46     
==========================================
+ Hits         7444     7454      +10     
+ Misses         50       41       -9     
+ Partials       32       31       -1     
Impacted Files Coverage 螖
src/schemathesis/cli/callbacks.py 98.80% <0.00%> (-1.20%) 猬囷笍
src/schemathesis/utils.py 97.70% <0.00%> (酶)
src/schemathesis/runner/serialization.py 98.14% <0.00%> (+6.48%) 猬嗭笍
src/schemathesis/_compat.py 89.18% <0.00%> (+13.51%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Bidaya0
Copy link
Contributor Author

Bidaya0 commented Sep 29, 2022

I think it would be better to update pytest to 7.1.3 instead as they dropped atomicwrites

@Stranger6667
I did this on the new commit, but it seems to never pass the test on windows.
Can you take a look, maybe someone who knows the project better will solve it faster.

@mdavis-xyz mdavis-xyz mentioned this pull request Sep 30, 2022
4 tasks
@Stranger6667 Stranger6667 merged commit ff5b51c into schemathesis:master Oct 10, 2022
@Stranger6667
Copy link
Member

I'll work on fixing tests now

t-huyeng added a commit to t-huyeng/hochwasserzentralen-api that referenced this pull request Oct 10, 2022
CommanderStorm added a commit to TUM-Dev/NavigaTUM that referenced this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] startup failure caused by dependencies, requires httpx
3 participants