Filters on API operations #1256
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stranger6667
force-pushed
the
dd/filter-operations
branch
from
dddfd03
to
58497bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
- Coverage 99.41% 99.15% -0.27%
==========================================
Files 82 83 +1
Lines 6152 6250 +98
Branches 1016 1043 +27
==========================================
+ Hits 6116 6197 +81
- Misses 18 30 +12
- Partials 18 23 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Stranger6667
force-pushed
the
dd/filter-operations
branch
from
58497bc
to
8c6ed21
Compare
Stranger6667
commented
Sep 27, 2021
Stranger6667
commented
Sep 27, 2021
| return self._filter_by(Exclude(predicate)) | ||
|
|
||
| def _filter_by(self, *predicates: BaseFilter) -> S: | ||
| filters = self.filters + list(predicates) |
There was a problem hiding this comment.
Maybe have a way to combine filters via OR
Stranger6667
commented
Sep 27, 2021
Stranger6667
force-pushed
the
dd/filter-operations
branch
2 times, most recently
from
74318c6
to
15af684
Compare
Stranger6667
commented
Oct 2, 2021
Stranger6667
commented
Oct 2, 2021
Stranger6667
force-pushed
the
dd/filter-operations
branch
from
fa9a3b3
to
a2956e3
Compare
Stranger6667
force-pushed
the
dd/filter-operations
branch
from
a2956e3
to
8542727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #703
Resolves #819
Resolves #1006
TODO:
parametrizeincludein testsinclude/excludejq-like filter ---include-by="x-foo == 42", where the expression is of form "JSONPath Operator Value"--include-method,--exclude-method, etc.excludeinclude/excludefor GraphQL schemaspathinsteadendpoint?In Schemathesis 4.0 it will be nice to remove those arguments & attributes