Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NoMethodError in random_password #850

Merged
merged 3 commits into from Apr 14, 2021
Merged

Fix NoMethodError in random_password #850

merged 3 commits into from Apr 14, 2021

Commits on Apr 14, 2021

  1. Fix NoMethodError in random_password 

    The method `random_password` uses `self` to retrieve the `password_length` configuration, but `self` is the `User` class, which has no `password_length` by default.

The length of the password should be fetch from Devise's own config
    @rhymes
    rhymes committed Apr 14, 2021
    Copy the full SHA
    b0e5d72 View commit details
    Browse the repository at this point in the history

  2. Update test

    @rhymes
    rhymes committed Apr 14, 2021
    Copy the full SHA
    4c8d353 View commit details
    Browse the repository at this point in the history

  3. Restore test using Validatable and support both scenarios

    @rhymes
    rhymes committed Apr 14, 2021
    Copy the full SHA
    a07ad58 View commit details
    Browse the repository at this point in the history