Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 18n locale - es.yml #833

Closed
wants to merge 1 commit into from
Closed

add 18n locale - es.yml #833

wants to merge 1 commit into from

Conversation

yshmarov
Copy link
Contributor

I think it would be a nice addition to add more locales :)

@scambra
Copy link
Owner

scambra commented Oct 19, 2020

We have locales in wiki, as devise does, I don't see the point in adding locales to devise invitable while devise doesn't have them.

@yshmarov
Copy link
Contributor Author

@scambra but devise has the gem devise-18n that contains all the locales.

I would see no point in creating a gem devise-invitable-i18n, as an addition to an addition 😃.

Right now any developer working with i18n & devise-invitable has to go to the wiki and copypaste all the locales he needs. Not a perfect user experience..

If you accept, I can do the work of adding all the locales from wiki to config

@scambra
Copy link
Owner

scambra commented Oct 19, 2020

@yshmarov I didn't know that gem, when I wrote devise invitable they only had locales in wiki. It would be great if you can send pull request with all locales from wiki then.

@yshmarov
Copy link
Contributor Author

ok!

@yshmarov
Copy link
Contributor Author

#834

@scambra scambra closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants