Skip to content

Commit

Permalink
use errors.details for assertions, fixing tests on rails 7.1
Browse files Browse the repository at this point in the history
  • Loading branch information
scambra committed Apr 19, 2023
1 parent 87228c1 commit 7e99041
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions test/models/invitable_test.rb
Expand Up @@ -371,10 +371,10 @@ def setup
existing_user.save(validate: false)
user = User.invite!(email: 'valid@email.com')
assert_equal user, existing_user
assert_equal ['has already been taken'], user.errors[:email]
assert_equal [{error: :taken}], user.errors.details[:email]
same_user = User.invite!(email: 'valid@email.com')
assert_equal same_user, existing_user
assert_equal ['has already been taken'], same_user.errors[:email]
assert_equal [{error: :taken}], same_user.errors.details[:email]
end

test 'should return a record with errors if user with pending invitation was found by e-mail' do
Expand All @@ -388,7 +388,7 @@ def setup

user = User.invite!(email: 'valid@email.com')
assert_equal user, existing_user
assert_equal ['has already been taken'], user.errors[:email]
assert_equal [{error: :taken}], user.errors.details[:email]
ensure
User.resend_invitation = resend_invitation
end
Expand All @@ -402,7 +402,7 @@ def setup
existing_user.save(validate: false)
user = User.invite!(email: 'valid@email.com', username: 'a' * 50)
assert_equal user, existing_user
assert_equal ['has already been taken'], user.errors[:email]
assert_equal [{error: :taken}], user.errors.details[:email]
refute_empty user.errors[:username]
ensure
User.validate_on_invite = validate_on_invite
Expand All @@ -412,13 +412,13 @@ def setup
test 'should return a new record with errors if e-mail is blank' do
invited_user = User.invite!(email: '')
assert invited_user.new_record?
assert_equal ["can't be blank"], invited_user.errors[:email]
assert_equal [{error: :blank}], invited_user.errors.details[:email]
end

test 'should return a new record with errors if e-mail is invalid' do
invited_user = User.invite!(email: 'invalid_email')
assert invited_user.new_record?
assert_equal ['is invalid'], invited_user.errors[:email]
assert_equal [{error: :invalid}], invited_user.errors.details[:email]
end

test 'should set all attributes with errors if e-mail is invalid' do
Expand All @@ -438,13 +438,13 @@ def setup
test 'should return a new record with errors if no invitation_token is found' do
invited_user = User.accept_invitation!(invitation_token: 'invalid_token')
assert invited_user.new_record?
assert_equal ['is invalid'], invited_user.errors[:invitation_token]
assert_equal [{error: :invalid}], invited_user.errors.details[:invitation_token]
end

test 'should return a new record with errors if invitation_token is blank' do
invited_user = User.accept_invitation!(invitation_token: '')
assert invited_user.new_record?
assert_equal ["can't be blank"], invited_user.errors[:invitation_token]
assert_equal [{error: :blank}], invited_user.errors.details[:invitation_token]
end

test 'should return record with errors if invitation_token has expired' do
Expand All @@ -454,7 +454,7 @@ def setup
invited_user.save(validate: false)
user = User.accept_invitation!(invitation_token: Thread.current[:token])
assert_equal user, invited_user
assert_equal ['is invalid'], user.errors[:invitation_token]
assert_equal [{error: :invalid}], user.errors.details[:invitation_token]
end

test 'should allow record modification using block' do
Expand Down

0 comments on commit 7e99041

Please sign in to comment.