Fix codecov coverage data upload #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is returning 400 on coverage report upload.
data upload fails.
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
+ Coverage 68.76% 75.55% +6.79%
==========================================
Files 159 159
Lines 30882 30882
Branches 3591 3591
==========================================
+ Hits 21234 23330 +2096
+ Misses 8950 6947 -2003
+ Partials 698 605 -93
|
ArthurKamalov
approved these changes
Jun 3, 2020
scripts/submit-codecov-data.sh
Outdated
| @@ -22,7 +22,8 @@ RETRY_DELAY=${RETRY_DELAY:-5} | |||
|
|
|||
| # Work around for temporary codecov API timing out | |||
| for (( i=0; i<$MAX_ATTEMPTS; ++i)); do | |||
| codecov --root=/home/circleci/scalyr-agent-2/ --disable gcov --file coverage.xml | |||
| # NOTE: We pass --required flag to the binary since we also want it to rAeturn non-zero if upload fails | |||
There was a problem hiding this comment.
Yep, thanks, fixed in 78401f5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes codecov coverage data uploads.
Background, Context
Codecov coverage upload started to fail with "400 bad request" error a couple of days ago (https://app.circleci.com/pipelines/github/scalyr/scalyr-agent-2/2930/workflows/05136b23-cf27-41ed-8b69-74bce5c4cdec/jobs/40054/parallel-runs/0/steps/0-108).
It looks like it's an issue with the version of the client we are currently using and a new one should fix it - codecov/codecov-python#268.
One of the reasons why we didn't spot this issue earlier was that we didn't consider "codecov data upload fatal" error as fatal.
I fixed that by adding
--requiredflag tocodecovbinary which will make it return with non-zero if the upload fails. This way we will spot issues like that sooner.