Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/SK-710 | FEDn cli - init server #544

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

niklastheman
Copy link
Contributor

FEDn cli

Run FEDn, list entities, start sessions etc. Default to running commands for localhost but can be configured, either by params or ENV:s.

Config includes:

  • FEDN_PROTOCOL - communication protocol (default http)
  • FEDN_HOST - controller host (default localhost)
  • FEDN_PORT - controller port (default 8092)
  • FEDN_TOKEN - token (used for authentication in FEDn Studio)
  • FEDN_AUTH_SCHEME - token auth scheme (Bearer/Token)

Added commands:

fedn run

  • start controller and combiner

fedn list

  • list entities (models, packages, clients etc)

fedn start session

  • start a new session

fedn upload

  • upload compute package or seed model

fedn config

  • see currently set ENV:s used as config
  • fedn config generate can be used to generate script to set the ENV:s
  • fedn config clear can be used to generate script to clear the ENV:s

Copy link
Member

@ahellander ahellander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall imo.

However, I wonder if we should consider refactoring the command naming scheme in relation to SK-746 (aka "python_env").

One model would be to follow the MLFlow Project convention to use "run" to exectute entry points as specified in fedn.yaml.

In that case we could perhaps do

fedn client start, stop
fedn combiner start, stop
fedn list

?

@niklastheman
Copy link
Contributor Author

Looks good overall imo.

However, I wonder if we should consider refactoring the command naming scheme in relation to SK-746 (aka "python_env").

One model would be to follow the MLFlow Project convention to use "run" to exectute entry points as specified in fedn.yaml.

In that case we could perhaps do

fedn client start, stop fedn combiner start, stop fedn list

?

I think if it harmonises better with MLFlow it's a good idea. We should bring @Wrede into the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants