enable sensitive log mode #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiatmakuri
approved these changes
Jan 2, 2024
song-william
commented
Jan 3, 2024
| @@ -156,6 +156,8 @@ def test_completion_sync_endpoint_not_found_returns_404( | |||
| assert response_1.status_code == 404 | |||
|
|
|||
|
|
|||
| # When enabling this test, other tests fail with "RunTumeError got Future <Future pending> attached to a different loop" | |||
| # https://github.com/encode/starlette/issues/1315#issuecomment-980784457 | |||
There was a problem hiding this comment.
To reproduce, run
GIT_TAG=$(git rev-parse HEAD) WORKSPACE=.. pytest -v -s tests/unit/api/test_tasks.py::test_create_streaming_task_success tests/unit/api/test_llms.py::test_completion_stream_success
When running these tests individually, we don't have an issue. Only when running both does this error appear. I put id(asyncio.get_running_loop()) throughout the create_completion_stream_task method and everything lined up and didn't error, so there must be something up with the TestClient library itself. Time-boxing this for now.
There was a problem hiding this comment.
I tried the small fixes in encode/starlette#1315 (comment), none of them seemed to work. I think we will either need to downgrade fastapi as folks suggested.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Enable sensitive log mode for use cases that want avoid logging user-specific data (e.g prompts and responses)
Test Plan and Usage Guide
Deploy in training and confirmed in datadog that logs no longer show up in vllm or logged by our gateway.