Deprecated either.{right,left}.value.

[Lasering]

Fixes #972

[SethTisue]

the deprecations will be reversed in 2.12.0-RC2 due to negative community feedback

they might still eventually go forward, so that doesn't necessarily mean this PR should be discarded — you could make a decision about what version of the code you like best, and perhaps leave feedback on scala/scala#5135

[wogan]

The deprecations are back as of 2.13 so can we get this patch applied please?

[markus1189]

Because of the time that passed since the last comment a quick check.

The deprecation is still in place in 2.13.1, does that mean it's going to stay?

[SethTisue]

The deprecation is still in place in 2.13.1, does that mean it's going to stay?

at present .right is deprecated (and I believe it will stay that way) but .left isn't, as per scala/scala#8012

Welcome to Scala 2.13.1 (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_202).
Type in expressions for evaluation. Or try :help.

scala 2.13.1> Right("foo").withLeft[Int]
res0: scala.util.Either[Int,String] = Right(foo)

scala 2.13.1> res0.left
res1: scala.util.Either.LeftProjection[Int,String] = LeftProjection(Right(foo))

scala 2.13.1> res0.right
                   ^
              warning: method right in class Either is deprecated (since 2.13.0): Either is now right-biased, use methods directly on Either
res2: scala.util.Either.RightProjection[Int,String] = RightProjection(Right(foo))

[markus1189]

Okay thanks for the heads up :)

[greg-wb-ap]

Would love to get this merged.
See also my comment on #972 - I think it makes sense to keep .left.value and just add .value directly on Either.

[clement-malaingre-ica]

Would really like to see this merged or some variation of it. Using the toOption workaround is just cluncky.

[satorg]

I wonder, what exactly is missing in this PR that prevents it from being merged finally? It hangs open since 2016 already.

[greg-wb-ap]

See also #1775 & #1746

[plinlor]

@cla-bot[bot] check

[cla-bot]

Hi @Lasering, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you.

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[rtyley]

This can be closed, as it was addressed in #1895.