Scala Native 0.5 Build #2322
Merged
Scala Native 0.5 Build #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has a few changes in build plugin, which requires to cleanup a bit build script. And one deprectated class was removed. Tested as: ``` export SCALANATIVE_VERSION=0.5.0 sbt clean sbt ++2.12.17 "project scalacticNative" clean publishLocal sbt ++2.13.10 "project scalacticNative" clean publishLocal sbt "project scalacticDottyNative" clean publishLocal sbt ++2.12.17 "project scalatestNative" clean publishLocal sbt ++2.13.10 "project scalatestNative" clean publishLocal sbt "project scalatestDottyNative" clean publishLocal sbt ++2.12.17 "project scalatestAppNative" clean publishLocal sbt ++2.13.10 "project scalatestAppNative" clean publishLocal sbt "project scalatestAppDottyNative" clean publishLocal ```
… into test-catap-scala-native-0.5-3
…ublishing scala-native build for scala 2.11.
|
@cheeseng this introduces update of dependencies and to be on safe side I suggest to release it as 3.2.19. |
@catap I think it should be fine, there's a scala-native 0.4 already published previously for 3.2.18 and it still can be used, or user may choose to use the 0.5 build (staged) if want to. Let's see if @bvenners likes it, starting 3.2.19 we should just have build for 0.5 though. :) |
|
On Thu, 18 Apr 2024 17:10:30 +0200, Chua Chee Seng wrote:
> @cheeseng this introduces update of dependencies and to be on safe side I suggest to release it as 3.2.19.
@catap I think it should be fine, there's a scala-native 0.4 already published previously for 3.2.18 and it still can be used, or user may choose to use the 0.5 build (staged) if want to. Let's see if @bvenners likes it, starting 3.2.19 we should just have build for 0.5 though. :)
Keep in mind that here I've updated scala-xml for example, and to have
3.2.18 which depends on different version of scala-xml may lead to issues.
…--
wbr, Kirill
|
This was referenced Apr 18, 2024
|
@cheeseng unfortently I was forced to upgrade scala-js to match version of sjs inside dependencies like scala-xml. |
catap
reviewed
Apr 19, 2024
| @@ -289,7 +289,7 @@ trait DottyBuild { this: BuildCommons => | |||
| initialCommands in console := """|import org.scalatest._ | |||
| |import org.scalactic._ | |||
| |import Matchers._""".stripMargin, | |||
| libraryDependencies += "org.scala-lang.modules" %%% "scala-xml" % "2.3.0", | |||
| libraryDependencies += "org.scala-lang.modules" %%% "scala-xml" % "2.1.0", | |||
There was a problem hiding this comment.
ah, this is dedicated project for Scala3Js. Got it.
bvenners
approved these changes
Apr 23, 2024
|
@catap Fyi Artifacts for scala-native 0.5 are up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #2318 , just minor tweaked for publishing 3.2.18 build for scala-native 0.5.