Scala 3 Infix #2158
Merged
Scala 3 Infix #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions for Scala 3 build.
…ons for Scala 3 build.
…or Scala 3 build.
…ons for Scala 3 build.
…ns for Scala 3 build.
…unctions for Scala 3 build.
…for Scala 3 build.
…functions for Scala 3 build.
…x in DSL functions for Scala 3 build.
…functions for Scala 3 build.
…ctions for Scala 3 build.
…n DSL functions for Scala 3 build.
… functions for Scala 3 build.
…nctions for Scala 3 build.
…tions for Scala 3 build.
…ctions for Scala 3 build.
… infix in DSL functions for Scala 3 build.
… infix in DSL functions for Scala 3 build.
… infix in DSL functions for Scala 3 build.
… infix in DSL functions for Scala 3 build.
… infix in DSL functions for Scala 3 build.
… infix in DSL functions for Scala 3 build.
… infix in DSL functions for Scala 3 build.
… infix in DSL functions for Scala 3 build.
… infix in DSL functions for Scala 3 build.
…for Scala 3 build.
bvenners
reviewed
Aug 16, 2022
| @@ -90,7 +90,7 @@ final class BeWord { | |||
| * ^ | |||
| * </pre> | |||
| **/ | |||
| def <[T : Ordering](right: T): Matcher[T] = | |||
| infix def <[T : Ordering](right: T): Matcher[T] = | |||
| new Matcher[T] { | |||
There was a problem hiding this comment.
I would remove infix from methods with symbolic names, because it is not required for symbols.
bvenners
reviewed
Aug 16, 2022
| @@ -352,7 +352,7 @@ final class BeWord { | |||
| * ^ | |||
| * </pre> | |||
| **/ | |||
| def apply[U](spread: Spread[U]): Matcher[U] = | |||
| infix def apply[U](spread: Spread[U]): Matcher[U] = | |||
| new Matcher[U] { | |||
There was a problem hiding this comment.
Hmm, I'm curious what syntax infix would support here?
|
@bvenners Thanks for the comments! I'll investigate and do the adjustments. Cheers. |
… and NotWord.scala.
…d and ResultOfGreaterThanComparison.
…rEqualToComparison, ResultOfLengthWordApplication and ResultOfLessThanComparison.
…ToComparison, ResultOfMessageWordApplication and ResultOfSizeWordApplication.
…ed in matchers DSL in the infix way.
…t used as infix operator in matchers DSL.
|
@bvenners I have made the adjustments, do you mind to review again? Thanks! |
bvenners
reviewed
Aug 21, 2022
dotty/matchers-core/src/main/scala/org/scalatest/matchers/dsl/NotWord.scala
Outdated
Show resolved
Hide resolved
bvenners
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made all functions involved in matchers DSL infix functions.