Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed building scalatests on scala-native-2.13 #1922

Open
wants to merge 1 commit into
base: 3.2.x-new
Choose a base branch
from

Conversation

catap
Copy link
Contributor

@catap catap commented Nov 16, 2020

This commit fixed a future issue with scala-native that can be discovered inside current scala-native master because it supports scala-2.13 :)

This commit fixed a future issue with scala-native that can be discovered inside
current scala-native master because it supports scala-2.13 :)
@cla-bot cla-bot bot added the cla-signed label Nov 16, 2020
@cheeseng
Copy link
Contributor

@catap Er, I wonder is there no plan to support scala-xml in scala-native? scala-js does seem supports it in release 1.3.0 and 2.0.0-M2 for scala-js 0.6 and 1.

@catap
Copy link
Contributor Author

catap commented Nov 18, 2020

@cheeseng at least it hasn't got scala-xml_2.13 for 1.0.6 :)

@catap
Copy link
Contributor Author

catap commented Nov 26, 2020

@cheeseng BTW I haven't see scala-xml for Scala-Native here: https://repo1.maven.org/maven2/org/scala-lang/modules/

:(

@cheeseng
Copy link
Contributor

@catap Ha, actually for 2.13 I can't find scala-native on maven repo, too. :)

@catap
Copy link
Contributor Author

catap commented Nov 26, 2020

@cheeseng scala native hasn't yet released and 2.12 and 2.13 are available only from master as snapshot ;)

@cheeseng
Copy link
Contributor

@catap Not seeing it being included in scala-xml build:

https://github.com/scala/scala-xml/blob/master/build.sbt#L164

May be first step will be to try add native build to scala-xml, not sure how hard it will be though.

@catap
Copy link
Contributor Author

catap commented Nov 26, 2020

@cheeseng so, if it hasn't included how does it works? :)

@catap
Copy link
Contributor Author

catap commented Nov 26, 2020

@cheeseng Looks like it never was includes: scala/scala-xml#282

So, I don't understand how it works right now.

@cheeseng
Copy link
Contributor

@catap It seems like the reason they dropped SN support is due to it requires scala 2.12, which SN did not support, but now 2.12 support is coming in master, right?

@catap
Copy link
Contributor Author

catap commented Nov 26, 2020

@cheeseng and 2.13 also. But I have no idea when the master will be released.

Here is the loop: I'm using quite complex project (its unit test) to find a bug inside scala-native master to help the team to release 2.12/2.13 without bugs [you can check the issue, I did find a few deep things, and a few inisde SJS by this code base].

All this unit tests are implemented on scalatests and right now I'm in the loop.

But I feel that start to broke it from adding support of SN to scala-xml is good idea but it can't be done until SN is released :)

@catap
Copy link
Contributor Author

catap commented Nov 27, 2020

@cheeseng I've touched scala-xml a bit and it seems isn't easy to make optional SN support.

Special that a new SN is planned to release on this year I'd like to wait until it is released :)

I will back to this PR ASAP

@SethTisue
Copy link
Contributor

SethTisue commented Dec 2, 2020

is there no plan to support scala-xml in scala-native?

not that I know of other than the "pull request welcome" here: scala/scala-xml#282

@catap
Copy link
Contributor Author

catap commented Dec 2, 2020

@SethTisue until SN is released with support 2.12 and 2.13 it is impossibly.

I've tried make cross compilation with optionally enabled SN, but it is quite a challenge that doesn't seems worth to be solved because the release should be in months.

@catap
Copy link
Contributor Author

catap commented Mar 13, 2024

This also quite old and seem to not be needed.

@cheeseng shall I close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants