Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ScalaCheck to 1.14.2 #1708

Open
wants to merge 1 commit into
base: 3.0.x
Choose a base branch
from

Conversation

ashawley
Copy link
Contributor

Greetings,

ScalaCheck 1.14.2 was released today. It is a bug fix release to 1.14.1, released a week ago, that was a minor update to ScalaCheck 1.14.0. Both are binary compatible to the current version, 1.14.0, that is specified in ScalaTest 3.0.

I'm not sure if ScalaTest has another 3.0.x release in its future, but it would be nice to get this bumped if you do happen to circle back.

Release notes:
https://github.com/typelevel/scalacheck/releases/tag/1.14.1
https://github.com/typelevel/scalacheck/releases/tag/1.14.2

Thanks for ScalaTest,
Aaron

@cheeseng
Copy link
Contributor

@ashawley Fyi it seems that I have to bump up scala-js to 0.6.29 also, using 0.6.28 I encountered the following when trying error:

org.scalajs.core.ir.IRVersionNotSupportedException: Failed to deserialize info of file compiled with Scala.js 0.6.29 (supported: 0.6.0, 0.6.13, 0.6.3, 0.6.17, 0.6.4, 0.6.6, 0.6.14, 0.6.8, 0.6.5, 0.6.15): /home/cheeseng/.ivy2/cache/org.scalacheck/scalacheck_sjs0.6_2.12/jars/scalacheck_sjs0.6_2.12-1.14.2.jar:org/scalacheck/Gen$Parameters$$anon$6.sjsir
	at org.scalajs.core.tools.io.VirtualSerializedScalaJSIRFile$class.info(VirtualFiles.scala:163)
	at org.scalajs.core.tools.io.MemVirtualSerializedScalaJSIRFile.info(MemFiles.scala:107)
	at org.scalajs.core.tools.io.IRFileCache$PersistentIRFile.<init>(IRFileCache.scala:247)
	at org.scalajs.core.tools.io.IRFileCache$PersistedFiles$$anonfun$update$4.apply(IRFileCache.scala:222)
	at org.scalajs.core.tools.io.IRFileCache$PersistedFiles$$anonfun$update$4.apply(IRFileCache.scala:222)
	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
	at scala.collection.immutable.List.foreach(List.scala:318)
	at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
	at scala.collection.AbstractTraversable.map(Traversable.scala:105)
	at org.scalajs.core.tools.io.IRFileCache$PersistedFiles.update(IRFileCache.scala:222)
	at org.scalajs.core.tools.io.IRFileCache$Cache$$anonfun$update$1$$anonfun$apply$mcV$sp$1.apply(IRFileCache.scala:100)
	at org.scalajs.core.tools.io.IRFileCache$Cache$$anonfun$update$1$$anonfun$apply$mcV$sp$1.apply(IRFileCache.scala:87)
	at scala.collection.immutable.List.foreach(List.scala:318)
	at org.scalajs.core.tools.io.IRFileCache$Cache$$anonfun$update$1.apply$mcV$sp(IRFileCache.scala:87)
	at org.scalajs.core.tools.io.IRFileCache$Cache$$anonfun$update$1.apply(IRFileCache.scala:84)
	at org.scalajs.core.tools.io.IRFileCache$Cache$$anonfun$update$1.apply(IRFileCache.scala:84)
	at org.scalajs.core.tools.io.IRFileCache.org$scalajs$core$tools$io$IRFileCache$$clearOnThrow(IRFileCache.scala:283)
	at org.scalajs.core.tools.io.IRFileCache$Cache.update(IRFileCache.scala:84)
	at org.scalajs.core.tools.io.IRFileCache$Cache.cached(IRFileCache.scala:80)
	at org.scalajs.sbtplugin.ScalaJSPluginInternal$$anonfun$26$$anonfun$apply$21.apply(ScalaJSPluginInternal.scala:493)
	at org.scalajs.sbtplugin.ScalaJSPluginInternal$$anonfun$26$$anonfun$apply$21.apply(ScalaJSPluginInternal.scala:493)
	at sbt.Attributed.map(Attributes.scala:199)
	at org.scalajs.sbtplugin.ScalaJSPluginInternal$$anonfun$26.apply(ScalaJSPluginInternal.scala:493)
	at org.scalajs.sbtplugin.ScalaJSPluginInternal$$anonfun$26.apply(ScalaJSPluginInternal.scala:483)
	at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
	at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
	at sbt.std.Transform$$anon$4.work(System.scala:63)
	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
	at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
	at sbt.Execute.work(Execute.scala:237)
	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
	at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
	at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: org.scalajs.core.ir.IRVersionNotSupportedException: This version (0.6.29) of Scala.js IR is not supported. Supported versions are: 0.6.0, 0.6.13, 0.6.3, 0.6.17, 0.6.4, 0.6.6, 0.6.14, 0.6.8, 0.6.5, 0.6.15
	at org.scalajs.core.ir.InfoSerializers$Deserializer.readHeader(InfoSerializers.scala:175)
	at org.scalajs.core.ir.InfoSerializers$Deserializer.deserialize(InfoSerializers.scala:106)
	at org.scalajs.core.ir.InfoSerializers$.deserializeWithVersion(InfoSerializers.scala:38)
	at org.scalajs.core.ir.InfoSerializers$.deserialize(InfoSerializers.scala:34)
	at org.scalajs.core.tools.io.VirtualSerializedScalaJSIRFile$class.info(VirtualFiles.scala:160)
	at org.scalajs.core.tools.io.MemVirtualSerializedScalaJSIRFile.info(MemFiles.scala:107)
	at org.scalajs.core.tools.io.IRFileCache$PersistentIRFile.<init>(IRFileCache.scala:247)
	at org.scalajs.core.tools.io.IRFileCache$PersistedFiles$$anonfun$update$4.apply(IRFileCache.scala:222)
	at org.scalajs.core.tools.io.IRFileCache$PersistedFiles$$anonfun$update$4.apply(IRFileCache.scala:222)
	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
	at scala.collection.immutable.List.foreach(List.scala:318)
	at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
	at scala.collection.AbstractTraversable.map(Traversable.scala:105)
	at org.scalajs.core.tools.io.IRFileCache$PersistedFiles.update(IRFileCache.scala:222)
	at org.scalajs.core.tools.io.IRFileCache$Cache$$anonfun$update$1$$anonfun$apply$mcV$sp$1.apply(IRFileCache.scala:100)
	at org.scalajs.core.tools.io.IRFileCache$Cache$$anonfun$update$1$$anonfun$apply$mcV$sp$1.apply(IRFileCache.scala:87)
	at scala.collection.immutable.List.foreach(List.scala:318)
	at org.scalajs.core.tools.io.IRFileCache$Cache$$anonfun$update$1.apply$mcV$sp(IRFileCache.scala:87)
	at org.scalajs.core.tools.io.IRFileCache$Cache$$anonfun$update$1.apply(IRFileCache.scala:84)
	at org.scalajs.core.tools.io.IRFileCache$Cache$$anonfun$update$1.apply(IRFileCache.scala:84)
	at org.scalajs.core.tools.io.IRFileCache.org$scalajs$core$tools$io$IRFileCache$$clearOnThrow(IRFileCache.scala:283)
	at org.scalajs.core.tools.io.IRFileCache$Cache.update(IRFileCache.scala:84)
	at org.scalajs.core.tools.io.IRFileCache$Cache.cached(IRFileCache.scala:80)
	at org.scalajs.sbtplugin.ScalaJSPluginInternal$$anonfun$26$$anonfun$apply$21.apply(ScalaJSPluginInternal.scala:493)
	at org.scalajs.sbtplugin.ScalaJSPluginInternal$$anonfun$26$$anonfun$apply$21.apply(ScalaJSPluginInternal.scala:493)
	at sbt.Attributed.map(Attributes.scala:199)
	at org.scalajs.sbtplugin.ScalaJSPluginInternal$$anonfun$26.apply(ScalaJSPluginInternal.scala:493)
	at org.scalajs.sbtplugin.ScalaJSPluginInternal$$anonfun$26.apply(ScalaJSPluginInternal.scala:483)
	at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
	at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
	at sbt.std.Transform$$anon$4.work(System.scala:63)
	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
	at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
	at sbt.Execute.work(Execute.scala:237)
	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
	at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
	at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
[error] (scalatestTestJS/test:scalaJSIR) org.scalajs.core.ir.IRVersionNotSupportedException: Failed to deserialize info of file compiled with Scala.js 0.6.29 (supported: 0.6.0, 0.6.13, 0.6.3, 0.6.17, 0.6.4, 0.6.6, 0.6.14, 0.6.8, 0.6.5, 0.6.15): /home/cheeseng/.ivy2/cache/org.scalacheck/scalacheck_sjs0.6_2.12/jars/scalacheck_sjs0.6_2.12-1.14.2.jar:org/scalacheck/Gen$Parameters$$anon$6.sjsir

Using scala-js 0.6.29 did work though.

@ashawley
Copy link
Contributor Author

I wasn't aware of this, no. Is it ok to update Scala.js 0.6.x in ScalaTest 3.0.x?

@cheeseng
Copy link
Contributor

I wasn't aware of this, no. Is it ok to update Scala.js 0.6.x in ScalaTest 3.0.x?

Yes, I think we can bump up scala-js version to 0.6.29 also for 3.0.x.

@plinlor
Copy link
Contributor

plinlor commented Aug 8, 2020

@cla-bot[bot] check

@cla-bot
Copy link

cla-bot bot commented Aug 8, 2020

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants