Skip to content

Commit

Permalink
Merge pull request #2281 from scalatest/3.3-retries-fix
Browse files Browse the repository at this point in the history
Merging this directly as it is already approved in 3.2 PR #2279
  • Loading branch information
cheeseng committed Sep 21, 2023
2 parents c27c76d + e8b96dd commit 783f4e5
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions jvm/core/src/main/scala/org/scalatest/Retries.scala
Expand Up @@ -15,8 +15,6 @@
*/
package org.scalatest

import org.scalatest.concurrent.SleepHelper
import org.scalatest.concurrent.SleepHelper
import org.scalatest.concurrent.SleepHelper
import time.Span

Expand Down Expand Up @@ -345,11 +343,15 @@ trait Retries {
val firstOutcome = blk
firstOutcome match {
case Failed(ex) =>
if (delay != Span.Zero)
SleepHelper.sleep(delay.millisPart, delay.nanosPart)
blk match {
case Succeeded => Canceled(Resources.testFlickered, ex)
case other => firstOutcome
}
case Canceled(ex) =>
if (delay != Span.Zero)
SleepHelper.sleep(delay.millisPart, delay.nanosPart)
blk match {
case Succeeded => Succeeded
case failed: Failed => failed // Never hide a failure.
Expand Down Expand Up @@ -567,7 +569,7 @@ trait Retries {
firstOutcome match {
case Failed(ex) =>
if (delay != Span.Zero)
SleepHelper.sleep(delay.millisPart)
SleepHelper.sleep(delay.millisPart, delay.nanosPart)
blk match {
case Succeeded => Canceled(Resources.testFlickered, ex)
case other => firstOutcome
Expand Down Expand Up @@ -782,8 +784,7 @@ trait Retries {
firstOutcome match {
case Canceled(ex) =>
if (delay != Span.Zero)
SleepHelper.sleep(delay.millisPart)
SleepHelper.sleep(delay.millisPart)
SleepHelper.sleep(delay.millisPart, delay.nanosPart)
blk match {
case Succeeded => Succeeded
case failed: Failed => failed // Never hide a failure.
Expand Down

0 comments on commit 783f4e5

Please sign in to comment.