Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify stage #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nab0310
Copy link

@nab0310 nab0310 commented Dec 18, 2018

This Pull Request is an extension of #59, adding a verify stage would help people who use docker to be able to use the scalatest-maven-plugin because it allows the post-integration test to run.

This is just a rough outline of what I think could be done. Obviously the file writing system is very crude but it was just my first draft. The Surefire plugin features a FailsafeSummaryXmlUtils class that provides utilities for file writing and reading that would provide a good solution to this problem.

@katrinsharp
Copy link
Collaborator

It's been sometime, so just wanted to see if it is still relevant.

@plinlor
Copy link

plinlor commented Aug 9, 2020

@cla-bot[bot] check

@cla-bot
Copy link

cla-bot bot commented Aug 9, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: nb051436.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Aug 9, 2020

The cla-bot has been summoned, and re-checked this pull request!

@rondefreitas
Copy link

I'm running into a similar issue with docker tests. It would be useful to have this functionality

@cheeseng
Copy link
Contributor

@nab0310 Really sorry for getting to this so late, I think this enhancement will be useful, though still in draft (it seems like the exception is always thrown in verify stage?), would you mind to sign the CLA?

Thanks.

throw new MojoExecutionException("There are test failures");
} else {
bufferedReader.close();
throw new MojoExecutionException("File has invalid content");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nab0310 It seems like we'll always fail in this verify stage, is it intended?

@cheeseng
Copy link
Contributor

cheeseng commented Jul 1, 2022

@cla-bot[bot] check

@cla-bot
Copy link

cla-bot bot commented Jul 1, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: nb051436.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Jul 1, 2022

The cla-bot has been summoned, and re-checked this pull request!

@cheeseng
Copy link
Contributor

cheeseng commented Jul 1, 2022

Hi @nab0310 , we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants