Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where environmentVariables or systemProperties can contain no… #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shawjef3
Copy link

${project.basedir} can't be used as an environmentVariable without this patch. It gives a class cast exception.

@shawjef3
Copy link
Author

shawjef3 commented Jul 6, 2017

I released this as me.jeffshaw.scalatest:scalatest-maven-plugin:2.0.0-M1.

@katrinsharp
Copy link
Collaborator

It's been sometime, so just wanted to see if it is still relevant.

@plinlor
Copy link

plinlor commented Aug 9, 2020

@cla-bot[bot] check

@cla-bot
Copy link

cla-bot bot commented Aug 9, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jeff Shaw.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Aug 9, 2020

The cla-bot has been summoned, and re-checked this pull request!

@cheeseng
Copy link
Contributor

cheeseng commented Jul 3, 2022

Hi @shawjef3 , we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants