Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScalametaParser: allow using even in scala 2 #2796

Merged
merged 1 commit into from
Jul 26, 2022
Merged

ScalametaParser: allow using even in scala 2 #2796

merged 1 commit into from
Jul 26, 2022

Conversation

kitbellew
Copy link
Contributor

Fixes #2785.

@kitbellew kitbellew requested a review from tgodzik July 25, 2022 13:58
@kitbellew kitbellew requested a review from dos65 July 25, 2022 14:02
@dos65
Copy link
Member

dos65 commented Jul 25, 2022

@kitbellew there is a failure in community-build scala.meta.parser.dotty.CommunityDottySuite

@kitbellew
Copy link
Contributor Author

@kitbellew there is a failure in community-build scala.meta.parser.dotty.CommunityDottySuite

thank you, fixed now.

dos65
dos65 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@dos65 dos65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kitbellew
Copy link
Contributor Author

@tgodzik does this look ok to you?

tgodzik
tgodzik approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this, I totally forgot about this one.

@kitbellew kitbellew merged commit ae9adf1 into scalameta:main Jul 26, 2022
@kitbellew kitbellew deleted the 2785 branch July 26, 2022 16:14
@tanishiking tanishiking mentioned this pull request Aug 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@dos65 dos65 dos65 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept and ignore using in args for Scala 2
3 participants
@kitbellew @dos65 @tgodzik