scala 2.13.9 #1676
Merged
scala 2.13.9 #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
force-pushed
the
scala2139
branch
4 times, most recently
from
e6d6771
to
31fc645
Compare
bjaglin
force-pushed
the
scala2139
branch
5 times, most recently
from
2675036
to
703dd74
Compare
bjaglin
commented
Sep 20, 2022
| if (isScala3.value) "-Xtarget:8" | ||
| else "-target:jvm-1.8" | ||
| if (isScala3.value) Seq("-Xtarget:8") | ||
| else if (isScala213.value) Seq("-release", "8") |
- bring back custom mimaPreviousArtifacts - avoid "missing dependency" on artifacts with full scala version - remove workaround no longer needed
bjaglin
commented
Sep 20, 2022
| override def requires = JvmPlugin && IvyPlugin | ||
| override def requires = | ||
| JvmPlugin && | ||
| SbtVersionPolicyPlugin // don't let it override our mimaPreviousArtifacts |
There was a problem hiding this comment.
By changing the order of plugin execution, this had a sneaky effect on publishing releases to sonatype as the (incorrect) publishTo defined in ScalafixBuildPlugin was effectively ignored until now.
[info] publishTo
-[info] Some(FileRepository(sonatype-local-bundle, Patterns(ivyPatterns=Vector(), artifactPatterns=Vector(/home/brice/git/opensource/scalafix/target/sonatype-staging/0.10.2/[organisation]/[module](_[scalaVersion])(_[sbtVersion])/[revision]/[artifact]-[revision](-[classifier]).[ext]), isMavenCompatible=true, descriptorOptional=false, skipConsistencyCheck=false), FileConfiguration(true, None)))
+[info] Some(sonatype-staging: https://oss.sonatype.org/service/local/staging/deploy/maven2)This prevents publishing releases
2022-09-20 22:12:38.036Z info [SonatypeService] sonatypeRepository : https://oss.sonatype.org/service/local - (SonatypeService.scala:26)
2022-09-20 22:12:38.041Z info [SonatypeService] sonatypeProfileName : ch.epfl.scala - (SonatypeService.scala:27)
[info] Preparing a new staging repository for [sbt-sonatype] scalafix 0.10.3
2022-09-20 22:12:38.043Z info [SonatypeClient] Reading staging repository profiles... - (SonatypeClient.scala:108)
2022-09-20 22:12:40.251Z info [SonatypeClient] Reading staging profiles... - (SonatypeClient.scala:120)
2022-09-20 22:12:43.932Z info [SonatypeClient] Creating a staging repository in profile ch.epfl.scala with a description key: [sbt-sonatype] scalafix 0.10.3 - (SonatypeClient.scala:126)
2022-09-20 22:12:51.705Z info [SonatypeClient] Created successfully: chepflscala-2407 - (SonatypeClient.scala:139)
2022-09-20 22:13:00.349Z info [SonatypeService] Found a previous staging repository [chepflscala-2405] status:open, profile:ch.epfl.scala(17f10a3293d844) description: [sbt-sonatype] scalafix 0.10.3 - (SonatypeService.scala:103)
2022-09-20 22:13:00.350Z info [SonatypeClient] Dropping staging repository [chepflscala-2405] status:open, profile:ch.epfl.scala(17f10a3293d844) description: [sbt-sonatype] scalafix 0.10.3 - (SonatypeClient.scala:229)
2022-09-20 22:13:00.430Z info [SonatypeService] Dropped successfully: chepflscala-2405 - (SonatypeService.scala:175)
2022-09-20 22:13:00.454Z error [Sonatype]
java.io.IOException: Supplied file /home/runner/work/scalafix/scalafix/target/sonatype-staging/0.10.3 is a not an existing directory!
at org.sonatype.spice.zapper.fs.AbstractDirectory.<init>(AbstractDirectory.java:32)
https://github.com/scalacenter/scalafix/actions/runs/3093699216/jobs/5006465269
#1678 (review) should address that
There was a problem hiding this comment.
Do you think it’s a problem that comes from sbt-version-policy? Please let me know if I need to fix something there :)
There was a problem hiding this comment.
Sure, thanks for chiming in! The publishTo issue was unrelated, the build was clearly wrong, and the change in plugin order accidentally made it visible. We can follow up on scalacenter/sbt-version-policy#138 though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1673
Towards #1675