Fixing bug in global initialization checker when accessing global object #20424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, BestEffortTastyWriter does not compile since PlainFile does not have a delete method, only File does.
|
@EnzeXing LGTM To avoid breaking the nightly build, I enabled |
EnzeXing
force-pushed
the
extend-whitelist
branch
3 times, most recently
from
3aebcac
to
81c5c57
Compare
EnzeXing
force-pushed
the
extend-whitelist
branch
from
81c5c57
to
ae74dcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the global initialization checker such that when accessing global object through full path, the checker immediately analyzes the initialization code of the corresponding object. Also adds test-cases for cyclic initialization causing deadlock
[test_scala2_library_tasty]