New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle scala cli in scala command #20351
base: main
Are you sure you want to change the base?
Conversation
… default scala-version
assemble a map of artefacts in maven format to both the local artefacts and library dependencies. Write them to dist/target/local-repo/maven2. Copy the local-repo to dist/target/pack/local. TODO: - evaluate how to remove lib dir in pack, only resolve from repo
1e4a234
to
acbd467
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can only comment on what's jumping at me. The timing is way too short to do a real review.
Even if I did find something it wouldn't get addressed and shipped in time at this point, so, to be blunt: why bother?
Edit: We can not guarantee that the Jar-based launcher works on JDK 17, so this must be |
A question is if a new scala-cli is released, will scala update it automatically, like |
The way it is currently implemented, the idea would be that each scala version is tied to a specific Scala CLI launcher. and Each scala release would come with whatever is the latest Scala CLI version at that moment |
|
28995e1
to
8df9d33
Compare
8df9d33
to
3c31ec9
Compare
bd37ec6
to
cbcd575
Compare
cbcd575
to
46696d5
Compare
|
|
||
val baseVersion = "3.5.0-RC1" | ||
|
||
val referenceVersion = "3.4.2-RC1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it right?
0fb67be
to
9c3357f
Compare
9c3357f
to
6c9e3f3
Compare
fixes #20098
Proposed changes to zip/targz archive:
/bin
directory store an extra launcher for Scala CLI (either JAR, or native per platform)./bin/scala[.bat]
is modified to invoke Scala CLI stored in/bin
/maven2
directory, which stores all the Jars and POM files necessary (in maven repo style) for scala-cli to invoke scala compiler offline (using the-r
launcher option)./lib
by aliases to the corresponding jar in/maven2
, OR delete/lib
and update references from scripts.scala-3.5.0-x86_64-pc-linux.tar.gz
(for the artefact that bundles the x64 linux launcher)[skip ci]