Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widen unsafe reach capabilities instead of erroring #20250

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Widen unsafe reach capabilities instead of erroring #20250

wants to merge 5 commits into from

Conversation

Linyxus
Copy link
Contributor

@Linyxus Linyxus commented Apr 23, 2024

Fixes #20204

@Linyxus Linyxus marked this pull request as draft April 23, 2024 13:05
@Linyxus Linyxus marked this pull request as ready for review April 25, 2024 14:35
@Linyxus Linyxus requested a review from odersky April 25, 2024 14:35
@Linyxus Linyxus assigned odersky and unassigned odersky Apr 25, 2024
@odersky
Copy link
Contributor

odersky commented Apr 25, 2024

reaches.scala still has errors?

@odersky odersky assigned Linyxus and unassigned odersky Apr 25, 2024
@Linyxus Linyxus assigned odersky and unassigned Linyxus May 6, 2024
@natsukagami natsukagami mentioned this pull request May 14, 2024
Draft
odersky
odersky requested changes May 19, 2024
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rearrange this PR into two commits:

  • One commit should contain all changes that we would want to revert when we change to existentials.
  • The other commit should contain tests and everything else that we want to keep.

@odersky odersky assigned Linyxus and unassigned odersky May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Linyxus Linyxus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expressiveness limitation when mapping a list of capabilities
2 participants
@Linyxus @odersky