Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Scala CLI as the scala runner command #20098

Open
5 of 10 tasks
Gedochao opened this issue Apr 5, 2024 · 1 comment · May be fixed by #20351
Open
5 of 10 tasks

Implement Scala CLI as the scala runner command #20098

Gedochao opened this issue Apr 5, 2024 · 1 comment · May be fixed by #20351
Assignees
@bishabosha @Gedochao @hamzaremmal
Labels
area:ci Issues tied with CI/CD workflows area:runner Issues tied to the scala runner command. itype:enhancement

Comments

@Gedochao
Copy link

Gedochao commented Apr 5, 2024 •
edited by bishabosha

Corresponding Scala CLI issue

Relevant docs

Requirements

  • set up downloading of Scala CLI JVM launcher from GitHub VirtusLab/scala-cli
  • download library dependencies to the dist/target/pack in maven repo style
  • fix scripts to wrap Scala CLI launcher, setting both the local repo and default scala version launcher options
    • update for windows (batch)
    • update for linux/mac (bash)
  • run any existing legacy (old) scala runner tests against the Scala CLI launcher on the scala/scala3 CI
  • use the Scala CLI launcher instead of the scala runner in official Scala 3 distributions
    • coursier
    • brew
    • SDKMAN
@Gedochao Gedochao added itype:enhancement area:runner Issues tied to the scala runner command. labels Apr 5, 2024
@Gedochao Gedochao added the area:ci Issues tied with CI/CD workflows label Apr 5, 2024
@Gedochao Gedochao mentioned this issue Apr 5, 2024
Open
10 tasks
@smarter smarter mentioned this issue Apr 5, 2024
Open
@bishabosha bishabosha mentioned this issue Apr 24, 2024
Open
@bishabosha
Copy link
Member

bishabosha commented May 1, 2024 •
edited

the strategy of downloading the launcher looks looks slightly problematic for script files compiled with a higher tasty version than scala-cli itself (e.g. a new minor release):

echo 'println(23)' >> local/foo.sc

scala-cli --cli-default-scala-version 3.5.0-RC1-bin-SNAPSHOT \
  -r file://dist/target/pack/maven2  \
  local/foo.sc \
  --server=false

Scala CLI (v1.3.0) cannot post process TASTY files from Scala 3.5.0-RC1-bin-SNAPSHOT.
This is not a fatal error since post processing only cleans up source paths in TASTY file.
It should not affect your application.
You may be getting this warning because you are using a newer version of Scala than the one supported by Scala CLI (v1.3.0).
Make sure your Scala CLI is up-to-date.
You may need to wait for 3.5.0-RC1-bin-SNAPSHOT support in a future version of Scala CLI.

23

however it still executes this simple script, as the error says, its only a problem "cleaning up" the source paths.
Is there a possible case that would actually fail?

This was referenced May 2, 2024
Merged
Open
This was referenced May 10, 2024
Open
Open
@bishabosha bishabosha mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bishabosha bishabosha

@Gedochao Gedochao

@hamzaremmal hamzaremmal

Labels
area:ci Issues tied with CI/CD workflows area:runner Issues tied to the scala runner command. itype:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bundle scala cli in scala command dotty-staging/dotty
3 participants
@bishabosha @Gedochao @hamzaremmal