Fix null-pointer regression in Vector#prependedAll and Vector#appendedAll
#9983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
force-pushed
the
ticket/t12564-vector-npe
branch
2 times, most recently
from
cdf2081
to
d0554f2
Compare
SethTisue
added
the
library:collections
retronym
force-pushed
the
ticket/t12564-vector-npe
branch
from
d0554f2
to
b447b3f
Compare
|
Seems you forgot to git-add the test file? |
retronym
force-pushed
the
ticket/t12564-vector-npe
branch
from
b447b3f
to
67fd672
Compare
|
any reason for the test not to be junit? |
NthPortal
approved these changes
Mar 31, 2022
|
Thank y'all so much for this fix! |
Also make a corresponding fix to appenededAll. This isn't exercised by the test case though.
lrytz
force-pushed
the
ticket/t12564-vector-npe
branch
from
67fd672
to
a0d3051
Compare
|
@jackkoenig thanks again for catching and minimizing the bug — super valuable. |
SethTisue
changed the title
Vector#prependedAll
SethTisue
changed the title
Vector#prependedAllVector#prependedAll and Vector#appendedAll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make a corresponding fix to
appendedAll. This isn't exercised by the test case though.Fixes scala/bug#12564