Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unused-import warnings easier to silence (support filtering by origin=) #9939

Merged
merged 2 commits into from Mar 3, 2022
Merged

Make unused-import warnings easier to silence (support filtering by origin=) #9939

merged 2 commits into from Mar 3, 2022

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Feb 14, 2022 •
edited by SethTisue

This allows nowarn by regex matching the fully-qualified selector string. For import a.{b, _}, match a.b or a._.

Fixes scala/bug#12326

@som-snytt
Import warnings have an origin
7cdfe09 
This allows nowarn by regex matching the fully-qualified
selector string. For `import a.{b, _}`, match `a.b` or `a._`.
@som-snytt
Stop the culling!
c663e3f
@scala-jenkins scala-jenkins added this to the 2.13.9 milestone Feb 14, 2022
@som-snytt som-snytt requested a review from lrytz February 14, 2022 09:20
@som-snytt
Copy link
Contributor Author

We need a label for "review-friendly!"

SethTisue
SethTisue approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@SethTisue SethTisue left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but ideally @lrytz would take a look as well, let's see if we attract his attention

@som-snytt
Copy link
Contributor Author

This work just stands on his shoulders.

lrytz
lrytz approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice :)

@lrytz lrytz merged commit 0bcc7dd into scala:2.13.x Mar 3, 2022
@som-snytt som-snytt mentioned this pull request Mar 11, 2022
Closed
@som-snytt som-snytt deleted the issue/12326 branch March 11, 2022 18:24
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Mar 11, 2022
@SethTisue SethTisue changed the title Import warnings have an origin Make unused-import warnings easier to silence Mar 11, 2022
@SethTisue SethTisue changed the title Make unused-import warnings easier to silence Make unused-import warnings easier to silence (by filtering with origin=) Mar 11, 2022
@SethTisue SethTisue changed the title Make unused-import warnings easier to silence (by filtering with origin=) Make unused-import warnings easier to silence (support filtering by origin=) Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

@SethTisue SethTisue SethTisue approved these changes

Assignees
No one assigned
Labels
release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.13.9
4 participants
@som-snytt @lrytz @SethTisue @scala-jenkins