Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JDK 18 #9702

Merged
merged 2 commits into from Jul 16, 2021
Merged

Support JDK 18 #9702

merged 2 commits into from Jul 16, 2021

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Jul 13, 2021 •
edited

  • make -target support JDK 18
  • upgrade to ASM 9.2, for JDK 18 support in optimizer

modeled after #9489
2.12.x PR is #9701

@scala-jenkins scala-jenkins added this to the 2.13.7 milestone Jul 13, 2021
@SethTisue SethTisue mentioned this pull request Jul 13, 2021
Merged
@SethTisue SethTisue added release-notes worth highlighting in next release notes prio:blocker release blocker (used only by core team, only near release time) labels Jul 13, 2021
@SethTisue
Copy link
Member Author

an example of a repo that was hitting running afoul of this on JDK 18:

[log4s] [error] Error while emitting LoggedEvent.scala
[log4s] [error] Unsupported class file major version 62

I verified locally that the problem goes away on 2.13.7-bin-5ac7cc5-SNAPSHOT:

[info] Project log4s-----------------------: SUCCESS (project rebuilt ok)

@SethTisue SethTisue requested a review from dwijnand July 15, 2021 19:00
@dwijnand dwijnand merged commit 5a8653f into scala:2.13.x Jul 16, 2021
@SethTisue SethTisue deleted the jdk18 branch July 16, 2021 12:55
@SethTisue SethTisue removed the prio:blocker release blocker (used only by core team, only near release time) label Jul 16, 2021
@SethTisue SethTisue changed the title support JDK 18 Support JDK 18 Oct 29, 2021
@griggt griggt mentioned this pull request Mar 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.13.7
3 participants
@SethTisue @dwijnand @scala-jenkins