Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to asm 9.0, for JDK 16 support #9477

Merged
merged 1 commit into from Feb 2, 2021
Merged

upgrade to asm 9.0, for JDK 16 support #9477

merged 1 commit into from Feb 2, 2021

Conversation

SethTisue
Copy link
Member

@scala-jenkins scala-jenkins added this to the 2.12.14 milestone Feb 2, 2021
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Feb 2, 2021
@SethTisue SethTisue mentioned this pull request Feb 2, 2021
Closed
@SethTisue
Copy link
Member Author

I tested locally by publishing 2.12.14-bin-2a60c31-SNAPSHOT locally and then in the community build doing ./narrow utest (utest is one of the repos that was failing on JDK 16) and version=2.12.14-bin-2a60c31-SNAPSHOT ./run.sh -l, and lo and behold:

[info] Project utest-----------------------: SUCCESS (project rebuilt ok)

so that's promising.

@SethTisue
Copy link
Member Author

full community build run: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk16-integrate-community-build/16/ queued

@SethTisue SethTisue mentioned this pull request Feb 2, 2021
Closed
dwijnand
dwijnand approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the community build went green too

@lrytz lrytz marked this pull request as ready for review February 2, 2021 11:11
@lrytz lrytz merged commit 3667278 into scala:2.12.x Feb 2, 2021
@SethTisue SethTisue deleted the asm-9 branch February 2, 2021 15:09
@smarter
Copy link
Member

smarter commented Feb 2, 2021

This upgrade should also allow you to add entries to

scala/src/compiler/scala/tools/nsc/backend/jvm/analysis/BackendUtils.scala

Lines 73 to 80 in 74b0e30

lazy val classfileVersion: LazyVar[Int] = perRunLazy(this)(compilerSettings.target match {
case "8" => asm.Opcodes.V1_8
case "9" => asm.Opcodes.V9
case "10" => asm.Opcodes.V10
case "11" => asm.Opcodes.V11
case "12" => asm.Opcodes.V12
// to be continued...
})
which I think is needed for-target to work with newer versions.

smarter added a commit to dotty-staging/dotty that referenced this pull request Feb 2, 2021
@smarter
Upgrade to ASM 9.0
dd0cbbb 
Keep up with Scala 2: scala/scala#9477
@smarter smarter mentioned this pull request Feb 2, 2021
Merged
smarter added a commit to dotty-staging/dotty that referenced this pull request Feb 2, 2021
@smarter
Upgrade to ASM 9.0
9fed887 
Keep up with Scala 2: scala/scala#9477
SethTisue added a commit to SethTisue/scala that referenced this pull request Feb 2, 2021
@SethTisue
upgrade to asm 9.0, for JDK 16 support
cc0aa0f 
fixes scala/bug#12328

forward-port of scala#9477. I want this on 2.13.x now, without waiting
around for the next big 2.12.x->2.13.x merge
@SethTisue SethTisue mentioned this pull request Feb 2, 2021
Merged
@SethTisue
Copy link
Member Author

@smarter #9481

michelou pushed a commit to michelou/dotty that referenced this pull request Feb 5, 2021
@smarter @michelou
Upgrade to ASM 9.0
251d436 
Keep up with Scala 2: scala/scala#9477
@retronym retronym mentioned this pull request Feb 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.12.14
5 participants
@SethTisue @smarter @dwijnand @lrytz @scala-jenkins