Use the upper bound of type skolems to enumerate subtypes #9472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
force-pushed
the
patmat-widen-tparam
branch
from
0733455
to
9cc5cf5
Compare
dwijnand
commented
Feb 1, 2021
|
It's difficult to be certain I'm not missing something, but this seems like exactly the fix I expected once as soon as I understood the bug report, and I can't think of any flaws or counterarguments to doing this. |
dwijnand
commented
Feb 2, 2021
src/compiler/scala/tools/nsc/transform/patmat/MatchAnalysis.scala
Outdated
Show resolved
Hide resolved
|
LGMT too |
|
I'll rebase this on #9473, so I don't rebase that one which is still under review. |
dwijnand
force-pushed
the
patmat-widen-tparam
branch
2 times, most recently
from
456ff30
to
b94fb2f
Compare
This was referenced Mar 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#12277