Support ConstantAnnotation when extracting literal annotation arguments #9463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows changing annotations like `deprecated` to extend `ConstantAnnotation` after a restarr.
|
@smarter is something similar needed for dotc? In nsc, annotations that are subtypes of ConstantAnnotation (and Java annotations) are represented differently internally. |
|
Honestly no idea, I never got what ConstantAnnotation was for and Dotty doesn't treat it specially. |
SethTisue
approved these changes
Jan 29, 2021
Then things should work the same if we ever change deprecated to ConstantAnnotation |
SethTisue
added a commit
to BalmungSan/scala
that referenced
this pull request
Mar 16, 2021
now that it's possible to do so, after scala#9463
SethTisue
added a commit
to BalmungSan/scala
that referenced
this pull request
Mar 17, 2021
now that it's possible to do so, after scala#9463
SethTisue
added a commit
to BalmungSan/scala
that referenced
this pull request
Mar 17, 2021
(now that it's possible to do so, after scala#9463) In this case of e.g. `implicitNotFound`, this makes it clearer that the custom error message must be a literal value. Fixes scala#10424 Co-authored-by: Seth Tisue <seth@tisue.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows changing annotations like
deprecatedto extendConstantAnnotationafter a restarr.See #9336 for context.