Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach typedConstructorPattern to ignore non-redefining unapplies #9462

Merged
merged 2 commits into from Feb 3, 2021
Merged

Teach typedConstructorPattern to ignore non-redefining unapplies #9462

merged 2 commits into from Feb 3, 2021

Commits on Jan 29, 2021

  1. Test size=23 unrelated/redefined unapplies 

    Just recording the current behaviour, to confirm the next commit doesn't
regress them.
    @dwijnand
    dwijnand committed Jan 29, 2021
    Copy the full SHA
    e9b1546 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Teach typedConstructorPattern to ignore non-redefining unapplies 

    In pos/t12250.scala Foo defines an unapply which doesn't redefine the
synthetic one.  Thus unapply is overloaded.  In the pattern being typed,
the synthetic one is indeed the one seeked, so despite being overloaded,
we should convertToCaseConstructor.
    @dwijnand
    dwijnand committed Feb 3, 2021
    Copy the full SHA
    0b8dd2a View commit details
    Browse the repository at this point in the history