Don't use iterator to modify the underlying Map in mapValuesInPlace
#8421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szeiger
reviewed
Sep 16, 2019
szeiger
reviewed
Sep 16, 2019
szeiger
reviewed
Sep 16, 2019
Override the method in HashMap with a more efficient implementation.
szeiger
approved these changes
Sep 16, 2019
| if (nonEmpty) this match { | ||
| case hm: mutable.HashMap[K, V] => hm.mapValuesInPlaceImpl(f) | ||
| case _ => | ||
| val array = this.toArray[Any] |
There was a problem hiding this comment.
We should add some more overrides (in 2.14 or as special cases here in 2.13) to avoid this default implementation.
There was a problem hiding this comment.
should we add overrides to filterInPlace as well?
|
Merging so we can start the community build. But further reviews are still very welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#11737.
mutable.Setis not affected, as it doesn't have amapInPlacemethod. I also looked through all otherxInPlacemethods I could find, and didn't see anything suspicious.In the spirit of scala/bug#7269, this should be back-ported to
Map.transformin 2.12/2.11.