Avoid memory leaks in Stream methods #8367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthPortal
added
the
library:collections
NthPortal
approved these changes
Aug 25, 2019
|
Huh, that's interesting. It fails when the optimizer is enabled. |
|
We had that before, maybe it's a different situation than the one fixed in 505b01c. I can take a look. |
lrytz
force-pushed
the
issue/11443
branch
4 times, most recently
from
9c07efd
to
51a890c
Compare
nice, the test works :-) |
what's the solution to this? |
lrytz
force-pushed
the
issue/11443
branch
2 times, most recently
from
c85daff
to
595bc2b
Compare
|
The |
|
I'll add |
The inliner replaces `return` instructions by `store`s to save the result of an inlined method. After loading that result, the local variable should be nulled out to preven memory leaks. This case was overlooked in 505b01c.
`Stream.collect/collectFirst/find` kept references to the original receiver of the call which prevented any part of the Stream from getting garbage collected as soon as possible. The previous implementation of `Stream.collect` claimed to avoid this but this only worked insofar as the resulting Stream did not hold on unnecessarily to any references to the original Stream. It still kept a reference to the original receiver while iterating over non-matching elements which can only be avoided with a tail-recursive implementation. Fixes scala/bug#11443
|
MiMa doesn't know about children of sealed classes either :-) added an exception. |
|
Phew, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stream.collect/collectFirst/findkept references to the originalreceiver of the call which prevented any part of the Stream from
getting garbage collected as soon as possible.
The previous implementation of
Stream.collectclaimed to avoid thisbut this only worked insofar as the resulting Stream did not hold on
unnecessarily to any references to the original Stream. It still kept
a reference to the original receiver while iterating over non-matching
elements which can only be avoided with a tail-recursive
implementation.
Fixes scala/bug#11443