Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop warning on higher-kinded usage without -language:higherKinds #8348

Merged
merged 1 commit into from Sep 9, 2019

Conversation

smarter
Copy link
Member

@smarter smarter commented Aug 19, 2019

See https://contributors.scala-lang.org/t/is-f-bound-polymorphism-useful/3618/5

Sadly, it seems that no deprecation warnings are reported on imports,
so import scala.language.higherKinds will not warn.

@scala-jenkins scala-jenkins added this to the 2.13.1 milestone Aug 19, 2019
@smarter smarter force-pushed the remove-higherKinds branch 2 times, most recently from 257c03e to 5ed1ac6 Compare August 19, 2019 18:19
Copy link
Member

@hrhino hrhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got to update a few checkfiles that were (accidentally) asserting the existence of this warning.

Would it make sense to remove the flag everywhere it's used in flags files?

@smarter
Copy link
Member Author

smarter commented Aug 19, 2019

Would it make sense to remove the flag everywhere it's used in flags files?

I think so yes. More generally it'd be nice to have a deprecation warning when using the -language:higherKinds flag but this is beyond my motivation level, help welcome :).

See https://contributors.scala-lang.org/t/is-f-bound-polymorphism-useful/3618/5

Sadly, it seems that no deprecation warnings are reported on imports,
so `import scala.language.higherKinds` will not warn.
@szeiger szeiger merged commit 456d3ef into scala:2.13.x Sep 9, 2019
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Sep 9, 2019
@SethTisue
Copy link
Member

(for the record, this was discussed and approved at a Scala team meeting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes worth highlighting in next release notes
Projects
None yet
5 participants