New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type inference involving wildcards #8129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriaanm
changed the title
Fix type infer regression introduced in scala/scala#6492
Fix type inference involving wildcards
Jun 7, 2019
Confirming that the problematic example from scala/scala-dev#184 progresses here. Before:
After:
|
Standalone test case that progresses:
|
retronym
reviewed
Jun 9, 2019
Pulling a few more threads in https://github.com/retronym/scala/tree/review/8129 |
Use == instead of =:= because we're looking for occurs, not equality. When we were using =:= to detect occurrences of type params in bounds, we'd accidentally unify too much (e.g. on wildcards / other type vars). Discovered while looking into why this doesn't type check: `java.util.stream.Stream.of(1,2,3).map(_.toString)` (scala/bug 11558) I noticed that there was cross talk between the type params of java.util.Function during type inference.
Didn't take the typeSymbol-comparing route because type constructor vars are too complicated to reason about when moving constraints around -- just preserve old behavior.
@retronym I incorporated a few strands of your review branch. LGTY? |
retronym
approved these changes
Jun 19, 2019
regression in overload resolution: scala/bug#11755 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use == instead of =:= because we're looking for occurs, not equality.
When we were using =:= to detect occurrences of type params in bounds,
we'd accidentally unify too much (e.g. on wildcards / other type vars).
Discovered while looking into why this doesn't type check:
java.util.stream.Stream.of(1,2,3).map(_.toString)
I noticed that there was cross talk between the type params of java.util.Function during type inference.
This partially regressed in #6492, but was actually wrong since the one with
*** empty log message ***
Fix scala/bug#11558
Relates to scala/scala-dev#184