Try any expression #8071
Merged
Try any expression #8071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, parsing `try` was special-cased for expressions
beginning with paren or brace. Perhaps that was to avoid odd
sights such as `try (1,2,3)` or `try { case _ => }`, but it
also broke `try { 1 } + 1 finally ()`.
This commit takes an arbitrary expression to `try`.
|
Try any patch twice. |
hrhino
approved these changes
May 18, 2019
| case FINALLY => in.nextToken(); expr() | ||
| case _ => EmptyTree | ||
| case FINALLY => in.nextToken() ; expr() | ||
| case _ => EmptyTree |
There was a problem hiding this comment.
We don't need scalafmt, just somfmt.
There was a problem hiding this comment.
I'd changed it to if-else in the earlier patch, but now I always prefer match. This is how I typed it back in.
|
|
||
| // was: value isDefinedAt is not a member of Int | ||
| // now: required: PartialFunction[Throwable,?] | ||
| //def f = try ??? catch 22 |
There was a problem hiding this comment.
I think that's a good error message. Why not test it?
There was a problem hiding this comment.
That will come back with the change to catch, which I'll attempt thricely.
There was a problem hiding this comment.
Pardon, this is the third time, not so much charmed as cut off at the knees. The next try for catch will be a fourth.
|
@hrhino this is when I laughed again at your previous comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, parsing
trywas special-cased for expressionsbeginning with paren or brace. Perhaps that was to avoid odd
sights such as
try (1,2,3)ortry { case _ => }, but italso broke
try { 1 } + 1 finally ().This commit takes an arbitrary expression to
try.This is just the parser change for
tryfrom #4400Fixes scala/bug#5887