Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore visibility of Erasure.needsJavaSig(...) #10762

Open
wants to merge 1 commit into
base: 2.12.x
Choose a base branch
from

Conversation

nbauma109
Copy link

@nbauma109 nbauma109 commented Apr 21, 2024

This method was used in Scala IDE, and now it does not compile because it was made private. I'm several behind, but I'd rather use the latest version. If that's not API, and there's no proper replacement, could we just restore the visibility ?

@scala-jenkins scala-jenkins added this to the 2.12.20 milestone Apr 21, 2024
@lrytz
Copy link
Member

lrytz commented Apr 22, 2024

@nbauma109 can you give a bit of background what you are doing? Which codebase are you compiling, and why?

@nbauma109
Copy link
Author

nbauma109 commented Apr 22, 2024

Scala IDE is a plugin project for Eclipse that was abandoned and it only works with Eclipse Oxygen which is very old. I want to update this project to build with latest version of scala 2.12.x and latest version of Eclipse.

I use a reflection hack to use the private method.
https://github.com/nbauma109/scala-ide/blob/9eb8e9b9d06a8954af0c7dfddfb5c9257f8d79f6/org.scala-ide.sdt.core/src/org/scalaide/core/internal/compiler/JavaSig.scala#L64

I'd rather use a normal method call like in original scala ide version:
https://github.com/scala-ide/scala-ide/blob/master/org.scala-ide.sdt.core/src/org/scalaide/core/internal/compiler/JavaSig.scala#L61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants