Normalize reference to undet param in stabilizer #10760
Merged
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details in the ticket.
lrytz
commented
May 7, 2024
| case t: AliasTypeRef if t.pre.termSymbol == vsym && context.undetparams.contains(t.normalize.typeSymbol) => | ||
| t.normalize | ||
| case t => t | ||
| }) |
There was a problem hiding this comment.
In short, given a method def m(b: FT, o: Option[I]): Int and a stabilizer is inserted at some call site stabilizer$1.m(b, None)
If FT is a type parameter, stabilizer$1.m has a MethodType where the parameter type FT is subsituted by asSeenFrom.
If FT is a type member, the parameter type ends up being AliasNoArgsTypeRef(stabilizer$1.type, FT), which is equivalent in theory, but instantiateTypeParams doesn't see through this alias.
More details in scala/bug#12987.
retronym
approved these changes
May 7, 2024
|
... also a pragmatic fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in the ticket.
Fixes scala/bug#12987.