Adjust deprecation config after Wconf #10750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/12984-wconf-deprecation
branch
from
801b298
to
820ad16
Compare
|
Somewhere in the Reporting adjusts the deprecation conf depending on deprecation.isSetByUser. Note: revisit |
som-snytt
force-pushed
the
issue/12984-wconf-deprecation
branch
2 times, most recently
from
c140068
to
ce202a3
Compare
som-snytt
force-pushed
the
issue/12984-wconf-deprecation
branch
from
ce202a3
to
7da120c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#12984
Fixes scala/bug#12664
Instead of adding wconf for deprecation when setting is selected, adjust the default filter. This ensures that user config is respected in this respect.
Otherwise, subtle order dependency is not friendly.
Instead of setting
maxwarn,nowarnis a trailing-Wconf:any:s. That is, any unconfigured warnings are silenced. Configured warnings are counted and reported in the usual way.