Adjust keepAlive for test under JDK 9 [ci: last-only] #10732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
sd/864-concur
branch
2 times, most recently
from
436d7a7
to
e9f8ec6
Compare
|
@lrytz this is quite tiresome. My review is that it should skip the test on JDK 8, but the twist is that the offending sub-test should be split into a separate test file with |
lrytz
reviewed
Apr 3, 2024
Comment on lines
1090
to
1110
| new ExecutionContextExecutorService { | ||
| // Members declared in scala.concurrent.ExecutionContext | ||
| def reportFailure(cause: Throwable): Unit = report(null, cause) | ||
|
|
||
| // Members declared in java.util.concurrent.Executor | ||
| def execute(r: Runnable): Unit = fjp.execute(r) | ||
|
|
||
| // Members declared in java.util.concurrent.ExecutorService | ||
| def awaitTermination(x$1: Long, x$2: java.util.concurrent.TimeUnit): Boolean = ??? | ||
| def invokeAll[T](x$1: java.util.Collection[_ <: java.util.concurrent.Callable[T]], x$2: Long, x$3: java.util.concurrent.TimeUnit): java.util.List[java.util.concurrent.Future[T]] = ??? | ||
| def invokeAll[T](x$1: java.util.Collection[_ <: java.util.concurrent.Callable[T]]): java.util.List[java.util.concurrent.Future[T]] = ??? | ||
| def invokeAny[T](x$1: java.util.Collection[_ <: java.util.concurrent.Callable[T]], x$2: Long, x$3: java.util.concurrent.TimeUnit): T = ??? | ||
| def invokeAny[T](x$1: java.util.Collection[_ <: java.util.concurrent.Callable[T]]): T = ??? | ||
| def isShutdown(): Boolean = fjp.isShutdown | ||
| def isTerminated(): Boolean = fjp.isTerminated | ||
| def shutdown(): Unit = fjp.shutdown() | ||
| def shutdownNow(): java.util.List[Runnable] = fjp.shutdownNow() | ||
| def submit(r: Runnable): java.util.concurrent.Future[_] = fjp.submit(r) | ||
| def submit[T](task: Runnable, res: T): java.util.concurrent.Future[T] = fjp.submit(task, res) | ||
| def submit[T](task: java.util.concurrent.Callable[T]): java.util.concurrent.Future[T] = fjp.submit(task) | ||
| } |
There was a problem hiding this comment.
Does ExecutionContext.fromExecutorService(fjp, report(null, _)) not work as expected here?
som-snytt
force-pushed
the
sd/864-concur
branch
3 times, most recently
from
78ff43a
to
5986bc0
Compare
|
the previous failure was spurious, so rebased. |
SethTisue
added
the
internal
|
I wonder if the spurious errors are due to using a spuriously ancient JDK. |
som-snytt
changed the title
som-snytt
force-pushed
the
sd/864-concur
branch
from
5986bc0
to
95d1211
Compare
|
This might also be intermittent |
|
/rebuild |
|
Yes, |
|
it's already known, infamously, as "the less famous flaky test". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/scala-dev#864
The test waits for the pool thread to terminate instead of interrupting it, probably to ensure that the thread wasn't planning on issuing spurious reports of exceptional circumstances.
The existing test used the default FJP available under JDK 8, which has a default keep-alive of 60 seconds, or one year in DX time.
This commit
reflectivelycreates a FJP under JDK 9+ with a short keep-alive, or uses a simple thread pool executor otherwise.